[ 
https://issues.apache.org/jira/browse/NIFI-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910421#comment-17910421
 ] 

Daniel Stieglitz edited comment on NIFI-14131 at 1/6/25 10:07 PM:
------------------------------------------------------------------

[~exceptionfactory] TestNaiveRevisionManager has 3 violations of 
UnusedPrivateField as all three private variables are not used. Intellij says 
this class is not used anywhere and there are no unit tests. Can this test 
class be deleted?


was (Author: JIRAUSER294662):
[~exceptionfactory] TestNaiveRevisionManager has 3 violations of 
UnusedPrivateField as all three private variables are not used. Intellij says 
this class is not used anywhere and there are not unit tests. Can this test 
class be deleted?

> PMD UnnecessarySemicolon rule not picking up instances of unnecessary 
> semicolons
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-14131
>                 URL: https://issues.apache.org/jira/browse/NIFI-14131
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> There are instances of redundant semicolons in unit and integration tests not 
> being picked up by the configured PMD UnnecessarySemicolon rule. These 
> instances can be found in
>  # EphemeralKeyStoreBuilderTest
>  # S3BundlePersistenceProviderIT
>  # TestExecuteSQLRecord
>  # TestXMLRecordSetWriter
>  # ByteRangeStreamingOutputTest
>  # StreamingOutputResponseBuilderTest
>  
> These can be picked up if the PMD plugin is configured for tests also. This 
> ticket should enable PMD checks for unit tests and make the necessary changes 
> to the test classes.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to