[
https://issues.apache.org/jira/browse/NIFI-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910435#comment-17910435
]
Daniel Stieglitz edited comment on NIFI-14131 at 1/6/25 10:57 PM:
------------------------------------------------------------------
[~exceptionfactory] There is the following violation
{code:java}
[WARNING] PMD Failure: org.apache.nifi.minifi.bootstrap.ShutdownHookTest:49
Rule:DontCallThreadRun Priority:4 Dont call Thread.run() explicitly, use
Thread.start().{code}
yet when I changed this the unit test failed the first time and then when I ran
this a second time it passed. Should we be concerned this becomes a flaky test?
was (Author: JIRAUSER294662):
[~exceptionfactory] There is the following violation
{code:java}
[WARNING] PMD Failure: org.apache.nifi.minifi.bootstrap.ShutdownHookTest:49
Rule:DontCallThreadRun Priority:4 Dont call Thread.run() explicitly, use
Thread.start().{code}
yet when I changed this the unit test failed the first time and then ran the
second time I ran it. Should we be concerned this becomes a flaky test?
> PMD UnnecessarySemicolon rule not picking up instances of unnecessary
> semicolons
> --------------------------------------------------------------------------------
>
> Key: NIFI-14131
> URL: https://issues.apache.org/jira/browse/NIFI-14131
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> There are instances of redundant semicolons in unit and integration tests not
> being picked up by the configured PMD UnnecessarySemicolon rule. These
> instances can be found in
> # EphemeralKeyStoreBuilderTest
> # S3BundlePersistenceProviderIT
> # TestExecuteSQLRecord
> # TestXMLRecordSetWriter
> # ByteRangeStreamingOutputTest
> # StreamingOutputResponseBuilderTest
>
> These can be picked up if the PMD plugin is configured for tests also. This
> ticket should enable PMD checks for unit tests and make the necessary changes
> to the test classes.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
