exceptionfactory commented on code in PR #9577:
URL: https://github.com/apache/nifi/pull/9577#discussion_r1920676308
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##########
@@ -567,12 +567,14 @@ public Response getBreadcrumbs(
)
public Response getFlowMetrics(
@Parameter(
- description = "The producer for flow file metrics. Each
producer may have its own output format.",
+ description = "The producer for flow file metrics. Each
producer may have its own output format. " +
+ "Allowed values: [prometheus, json]",
Review Comment:
Instead of indicating the allowed values in the description, it should be
possible to provide `schema` that indicates allowed values.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/prometheusutil/NiFiMetricsRegistry.java:
##########
@@ -275,5 +275,35 @@ public NiFiMetricsRegistry() {
.help("Provenance repository free space in bytes")
.labelNames("instance", "component_type", "component_name",
"component_id", "parent_id", "repo_identifier")
.register(registry));
+
+ nameToGaugeMap.put("PROCESSING_PERF_CPU_MILLIS", Gauge.build()
+ .name("nifi_processing_cpu_duration")
Review Comment:
Although it is longer, including `performance` in the name would provide
better alignment with the source of the information.
```suggestion
.name("nifi_processing_performance_cpu_duration")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
