[ 
https://issues.apache.org/jira/browse/NIFI-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914228#comment-17914228
 ] 

David Handermann commented on NIFI-14169:
-----------------------------------------

Thanks for asking [~dstiegli1]. I noticed this rule when previously reviewing.

Although it seems like a good practice in general, I think it is significantly 
less useful than many other PMD rules. The issues you noted with abstract test 
classes are one sign that this rule is not as helpful. So although the general 
convention seems like a good one, it seems better to avoid adding this rule.

> Apply PMD's JUnit5TestShouldBePackagePrivate across the code base
> -----------------------------------------------------------------
>
>                 Key: NIFI-14169
>                 URL: https://issues.apache.org/jira/browse/NIFI-14169
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to