mosermw commented on code in PR #9685:
URL: https://github.com/apache/nifi/pull/9685#discussion_r1942009588
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-rules/pom.xml:
##########
@@ -23,7 +23,13 @@
<artifactId>nifi-standard-rules</artifactId>
<packaging>jar</packaging>
- <dependencies />
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <scope>provided</scope>
Review Comment:
This code has to check the return value of
connection.getLoadBalanceStrategy() against configured strategies to see if it
would be allowed/disallowed. An alternative to referencing nifi-framework-api
is to hard-code those strings directly in this rule.
I suspect the LoadBalanceStrategy and LoadBalanceCompression classes belong
in nifi-api. But that's a separate discussion ;).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
