markobean commented on code in PR #9685:
URL: https://github.com/apache/nifi/pull/9685#discussion_r1943010256
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-rules/pom.xml:
##########
@@ -23,7 +23,13 @@
<artifactId>nifi-standard-rules</artifactId>
<packaging>jar</packaging>
- <dependencies />
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-framework-api</artifactId>
+ <scope>provided</scope>
Review Comment:
I agree with @mwmoser - he has both identified the reason for the dependency
and the fact that perhaps the values I am after are currently misplaced.
Similar to wanting to narrow the granularity of this rule, modifying APIs
within this particular ticket is scope creep and I don't think we should go
there. In fact, since `nifi-api` is now a separate project, it is not even
possible. I will look into the two APIs and see if it can be handled in a
future ticket (and create one if it seems like a good idea.)
I do not recommend hard-coding values which are otherwise available in an
API. The JAR is only 167 KB and will not be particularly obtrusive to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
