[ 
https://issues.apache.org/jira/browse/NIFI-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929208#comment-17929208
 ] 

Dariusz Seweryn commented on NIFI-14284:
----------------------------------------

One thing to have in mind:

If anyone used any of these properties in another place and depends on the 
`getName()` function return value, the migration may break their code.

> ConsumeKinesisStream props name convention update
> -------------------------------------------------
>
>                 Key: NIFI-14284
>                 URL: https://issues.apache.org/jira/browse/NIFI-14284
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 2.2.0
>            Reporter: Dariusz Seweryn
>            Priority: Trivial
>
> The ConsumeKinesisStream processor contains properties which names use the 
> previous convention, like:
> ```
> public static final PropertyDescriptor FAILOVER_TIMEOUT = new 
> PropertyDescriptor.Builder()
> .displayName("Failover Timeout")
> .name("amazon-kinesis-stream-failover-timeout")
> .description("Kinesis Client Library failover timeout")
> .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
> .defaultValue("30 secs")
> .required(true).build();
> ```
>  
> The current convention is to have `displayName` and `name` to be equal. All 
> properties in the class could be -updated- migrated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to