[
https://issues.apache.org/jira/browse/NIFI-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929199#comment-17929199
]
David Handermann commented on NIFI-14284:
-----------------------------------------
Thanks for proposing these changes [~dariuszseweryn], and thanks for the
feedback [~joewitt].
For clarification on the last point, the migrateProperties() method supports
changing property names without introducing break changes. With that approach
in mind, the current property naming can be replaced with the more modernized
naming approach. As long as the migrateProperties() method is defined
correctly, indicating the property name change, this will work automatically on
upgrade. As the "amazon-kinesis" prefix is generally unnecessary, this is a
good opportunity to modernize the property names. Although changing it is not
required, introducing new support for a wrapper record strategy as described in
NIFI-14285 seems like a good prompt to make these changes.
> ConsumeKinesisStream props name convention update
> -------------------------------------------------
>
> Key: NIFI-14284
> URL: https://issues.apache.org/jira/browse/NIFI-14284
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 2.2.0
> Reporter: Dariusz Seweryn
> Priority: Trivial
>
> The ConsumeKinesisStream processor contains properties which names use the
> previous convention, like:
> ```
> public static final PropertyDescriptor FAILOVER_TIMEOUT = new
> PropertyDescriptor.Builder()
> .displayName("Failover Timeout")
> .name("amazon-kinesis-stream-failover-timeout")
> .description("Kinesis Client Library failover timeout")
> .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
> .defaultValue("30 secs")
> .required(true).build();
> ```
>
> The current convention is to have `displayName` and `name` to be equal. All
> properties in the class could be -updated- migrated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
