martinzink commented on code in PR #1936:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1936#discussion_r1967334853
##########
extensions/standard-processors/modbus/ReadModbusFunctions.h:
##########
@@ -69,7 +69,7 @@ class ReadModbusFunction {
const uint8_t unit_id_;
};
-class ReadCoilStatus final : public ReadModbusFunction {
+class ReadCoilStatus : public ReadModbusFunction {
Review Comment:
Due to a bug in the latest apple clang final classes break dynamic_cast
https://stackoverflow.com/questions/79192304/macos-xcode-16-breaks-dynamic-cast-for-final-types-defined-in-shared-library
Should we `-fno-assume-unique-vtables` or just remove the finals here (we
rely on dynamic_cast for tests only) but this might also come up somewhere that
is not covered by tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
