szaszm commented on code in PR #1936:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1936#discussion_r1967341885
##########
extensions/standard-processors/modbus/ReadModbusFunctions.h:
##########
@@ -69,7 +69,7 @@ class ReadModbusFunction {
const uint8_t unit_id_;
};
-class ReadCoilStatus final : public ReadModbusFunction {
+class ReadCoilStatus : public ReadModbusFunction {
Review Comment:
I think removing `final` in the affected cases is fine, and better if there
are only few cases. `-f` flags change the compiler in incompatible ways, it's
best to avoid them IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
