szaszm commented on code in PR #1947: URL: https://github.com/apache/nifi-minifi-cpp/pull/1947#discussion_r2010245182
##########
PROCESSORS.md:
##########
@@ -2449,6 +2449,7 @@ In the list below, the names of required properties
appear in bold. Any other pr
| **Multipart Part Size** | 5 GB |
| Specifies the part size for use
when the PutS3Multipart Upload API is used. Flow files will be broken into
chunks of this size for the upload process, but the last part sent can be
smaller since it is not padded. The valid range is 5MB to 5GB.
|
| **Multipart Upload AgeOff Interval** | 60 min |
| Specifies the interval at which
existing multipart uploads in AWS S3 will be evaluated for ageoff. When
processor is triggered it will initiate the ageoff evaluation if this interval
has been exceeded.
|
| **Multipart Upload Max Age Threshold** | 7 days |
| Specifies the maximum age for
existing multipart uploads in AWS S3. When the ageoff process occurs, any
upload older than this threshold will be aborted.
|
+| **Checksum Algorithm** | CRC64NVME |
CRC32<br/>CRC32C<br/>SHA1<br/>SHA256<br/>CRC64NVME
| Checksum algorithm used
to verify the uploaded object.
|
Review Comment:
Now that this is added and the default is not MD5, can a user make minifi
FIPS compliant by just enabling FIPS support and following the FIPS steps
(config generation) in CONFIGURE.md?
##########
extensions/aws/s3/S3Wrapper.h:
##########
@@ -90,6 +100,14 @@ inline constexpr std::array<std::pair<std::string_view,
Aws::S3::Model::ObjectCa
{"AwsExecRead", Aws::S3::Model::ObjectCannedACL::aws_exec_read},
}};
+inline constexpr std::array<std::pair<std::string_view,
Aws::S3::Model::ChecksumAlgorithm>, 5> CHECKSUM_ALGORITHM_MAP {{
+ {"CRC32", Aws::S3::Model::ChecksumAlgorithm::CRC32},
+ {"CRC32C", Aws::S3::Model::ChecksumAlgorithm::CRC32C},
+ {"SHA1", Aws::S3::Model::ChecksumAlgorithm::SHA1},
+ {"SHA256", Aws::S3::Model::ChecksumAlgorithm::SHA256},
+ {"CRC64NVME", Aws::S3::Model::ChecksumAlgorithm::CRC64NVME}
+}};
Review Comment:
Should we add MD5 here, since it was the default, or would it add no value
at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
