lordgamez commented on code in PR #1947:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1947#discussion_r2010267824
##########
extensions/aws/s3/S3Wrapper.h:
##########
@@ -90,6 +100,14 @@ inline constexpr std::array<std::pair<std::string_view,
Aws::S3::Model::ObjectCa
{"AwsExecRead", Aws::S3::Model::ObjectCannedACL::aws_exec_read},
}};
+inline constexpr std::array<std::pair<std::string_view,
Aws::S3::Model::ChecksumAlgorithm>, 5> CHECKSUM_ALGORITHM_MAP {{
+ {"CRC32", Aws::S3::Model::ChecksumAlgorithm::CRC32},
+ {"CRC32C", Aws::S3::Model::ChecksumAlgorithm::CRC32C},
+ {"SHA1", Aws::S3::Model::ChecksumAlgorithm::SHA1},
+ {"SHA256", Aws::S3::Model::ChecksumAlgorithm::SHA256},
+ {"CRC64NVME", Aws::S3::Model::ChecksumAlgorithm::CRC64NVME}
+}};
Review Comment:
Previously MD5 hash was added in the Content-MD5 header if no Checksum
Algorithm was provided, but MD5 was not an option that could be selected for
the Checksum Algorithm. With the latest SDK version this is no longer the case,
if no Checksum Algorithm is provided then CRC64NVME is selected and used by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
