Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98614712
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
---
@@ -212,9 +215,21 @@ public void onTrigger(final ProcessContext context,
final ProcessSessionFactory
final Map<String, String> statePropertyMap = new
HashMap<>(stateMap.toMap());
//If an initial max value for column(s) has been specified using
properties, and this column is not in the state manager, sync them to the state
property map
- for(final Map.Entry<String,String> maxProp :
maxValueProperties.entrySet()){
- if
(!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
- statePropertyMap.put(maxProp.getKey().toLowerCase(),
maxProp.getValue());
+ for (final Map.Entry<String, String> maxProp :
maxValueProperties.entrySet()) {
+ String maxPropKey = maxProp.getKey().toLowerCase();
+ String fullyQualifiedMaxPropKey = getStateKey(tableName,
maxPropKey);
+ if (!statePropertyMap.containsKey(fullyQualifiedMaxPropKey)) {
+ String newMaxPropValue;
+ // If we can't find the value at the fully-qualified key
name, it is possible (under a previous scheme)
+ // the value has been stored under a key that is only the
column name. Fall back to check the column name,
+ // but store the new initial max value under the
fully-qualified key.
+ if (statePropertyMap.containsKey(maxPropKey)) {
+ newMaxPropValue = statePropertyMap.get(maxPropKey);
+ } else {
+ newMaxPropValue = maxProp.getValue();
--- End diff --
For the unknown column type issue when initial max value and dynamic max
value columns as described in [this comment](#issuecomment-274592165), how
about adding a query using "1 = 0" WHERE clause here to populate columnTypeMap
if a type for the column doesn't exist in the map?
Since this line can only be achieved at the initial execution for a given
table, it should be safe to do so like AbstractDatabaseFetchProcessor.setup()
does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
