Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98684537
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
---
@@ -212,9 +215,21 @@ public void onTrigger(final ProcessContext context,
final ProcessSessionFactory
final Map<String, String> statePropertyMap = new
HashMap<>(stateMap.toMap());
//If an initial max value for column(s) has been specified using
properties, and this column is not in the state manager, sync them to the state
property map
- for(final Map.Entry<String,String> maxProp :
maxValueProperties.entrySet()){
- if
(!statePropertyMap.containsKey(maxProp.getKey().toLowerCase())) {
- statePropertyMap.put(maxProp.getKey().toLowerCase(),
maxProp.getValue());
+ for (final Map.Entry<String, String> maxProp :
maxValueProperties.entrySet()) {
+ String maxPropKey = maxProp.getKey().toLowerCase();
+ String fullyQualifiedMaxPropKey = getStateKey(tableName,
maxPropKey);
+ if (!statePropertyMap.containsKey(fullyQualifiedMaxPropKey)) {
+ String newMaxPropValue;
+ // If we can't find the value at the fully-qualified key
name, it is possible (under a previous scheme)
+ // the value has been stored under a key that is only the
column name. Fall back to check the column name,
+ // but store the new initial max value under the
fully-qualified key.
+ if (statePropertyMap.containsKey(maxPropKey)) {
+ newMaxPropValue = statePropertyMap.get(maxPropKey);
+ } else {
+ newMaxPropValue = maxProp.getValue();
--- End diff --
I was trying to limit the number of queries GenerateTableFetch has to make,
since the real work will be done downstream. In this case, an invariant is
that a columnTypeMap entry exists iff a max-value entry exists. Otherwise the
first time I'll be doing a SELECT MAX(max-value-column) without a WHERE clause
(since there is no max-value entry) so I don't have to worry about type
conversions for literals. The type of the value(s) is the same as the type of
the MAX(values), so the first time I can fill both the columnType map and the
max-value map.
Is there a path where the current approach does not suffice? If so then I
can certainly add an extra query.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
