mosermw commented on PR #9950: URL: https://github.com/apache/nifi/pull/9950#issuecomment-2902553924
Thanks for this contribution @hunter-goller. I need to spend some time testing this, but I wanted to provide some initial feedback that I noticed. The NoOpProvenanceRepository implementation looks code from a code standpoint. I think the Javadocs are a bit heavy for its intended purpose, and you may remove some of those Javadoc annotations that are simply duplicates of what appears in the ProvenanceRepository interface. Please move the NoOpProvenanceRepository implementation into the nifi-volatile-provenance-repository module. Don't stress about the word "volatile" in that module name, I think it would appreciate not being alone in that jar anymore. NoOpProvenanceRepository doesn't really belong in the core framework. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
