mosermw commented on code in PR #9950: URL: https://github.com/apache/nifi/pull/9950#discussion_r2103393404
########## nifi-docs/src/main/asciidoc/administration-guide.adoc: ########## @@ -3029,13 +3029,16 @@ For example, if `nifi.content.repository.archive.max.usage.percentage` is `50%` The Provenance Repository contains the information related to Data Provenance. The next four sections are for Provenance Repository properties. +NOTE: NiFi also supports a `NoOpProvenanceRepository` implementation that does not persist any provenance events. This implementation is useful for testing or when provenance tracking is disabled to minimize resource usage. To use it, set the property: + |==== |*Property*|*Description* |`nifi.provenance.repository.implementation`|The Provenance Repository implementation. The default value is `org.apache.nifi.provenance.WriteAheadProvenanceRepository`. To store provenance events in memory instead of on disk (in which case all events will be lost on restart, and events will be evicted in a first-in-first-out order), set this property to `org.apache.nifi.provenance.VolatileProvenanceRepository`. This leaves a configurable number of Provenance Events in the Java heap, so the number of events that can be retained is very limited. +Alternatively, to disable event storage entirely, set this property to `org.apache.nifi.provenance.NoOpProvenanceRepository`. Review Comment: After removing the above note, you can capture its purpose by including info here, such as "to disable provenance event storage entirely and reduce resource usage" ########## nifi-docs/src/main/asciidoc/administration-guide.adoc: ########## @@ -3029,13 +3029,16 @@ For example, if `nifi.content.repository.archive.max.usage.percentage` is `50%` The Provenance Repository contains the information related to Data Provenance. The next four sections are for Provenance Repository properties. +NOTE: NiFi also supports a `NoOpProvenanceRepository` implementation that does not persist any provenance events. This implementation is useful for testing or when provenance tracking is disabled to minimize resource usage. To use it, set the property: Review Comment: I don't think this note is needed, as it's covered below in the nifi.provenance.repository.implementation description. ########## nifi-docs/src/main/asciidoc/user-guide.adoc: ########## @@ -1781,6 +1781,27 @@ or if the invocation times out, the Provenance Events are discard. There are, ho rolled back, the fact that data was sent, or that some remote invocation occurred cannot be rolled back. Therefore, the Provenance Repository is still updated to note the fact that these events occurred. +NiFi also supports a `NoOpProvenanceRepository` implementation that does not store any provenance events. Review Comment: This is the Stateless Execution Engine section of the User Guide, so I don't think this addition belongs here. It looks like the Data Provenance section below, right after the WriteAheadProvenanceRepository section, would be a better location. Also be sure to put the NoOpProvenanceRepository header first, then add paragraphs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
