dan-s1 commented on PR #10000:
URL: https://github.com/apache/nifi/pull/10000#issuecomment-2980925551

   > Thanks for working on this improvement @dan-s1.
   > 
   > The general implementation approach is along the lines of the discussion 
in Jira, but the property values do not quite align.
   > 
   > The existing `Use Strategy Row` strategy value needs to be retained to 
avoid breaking changes.
   > 
   > Instead of introducing two new options with `Standard` and `All`, I was 
thinking that there would be a new dependent property with selectable values of 
`Standard` and `All Rows`. The property would be selectable based on existing 
schema inference strategy options, instead of introducing new ones.
   
   I thought I avoided breaking changes by adding `migrateProperties` in 
ExcelReader (line 160)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to