dan-s1 commented on code in PR #10000: URL: https://github.com/apache/nifi/pull/10000#discussion_r2162484983
########## nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/StartingRowStrategy.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.excel; + +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.DescribedValue; + +public enum StartingRowStrategy implements DescribedValue { + STANDARD("Use %s rows after the starting row.".formatted(StartingRowStrategy.NUM_ROWS_TO_DETERMINE_TYPES)), + ALL("Use all the rows after the starting row."); + + static final int NUM_ROWS_TO_DETERMINE_TYPES = 10; // NOTE: This number is arbitrary. + static final AllowableValue USE_STARTING_ROW = new AllowableValue("Use Starting Row", "Use Starting Row", Review Comment: Can I place it as a variable in class `ExcelStartingRowSchemaInference` ? It was in that class before I had renamed the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
