szaszm commented on code in PR #1984:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1984#discussion_r2164112765
##########
extensions/standard-processors/processors/PutUDP.cpp:
##########
@@ -120,10 +120,10 @@ void PutUDP::onTrigger(core::ProcessContext& context,
core::ProcessSession& sess
session.transfer(flow_file, Failure);
};
- resolve_hostname()
+ (void)(resolve_hostname()
Review Comment:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es48-avoid-casts
The C++ Core Guidelines recommends assignment to `std::ignore` to ignore
`[[nodiscard]]` values. I think it may be slightly better, but it's fine if you
like this more.
##########
extensions/lua/tests/TestExecuteScriptProcessorWithLuaScript.cpp:
##########
@@ -46,8 +46,8 @@ TEST_CASE("Script engine is not set",
"[executescriptMisconfiguration]") {
auto execute_script = plan->addProcessor("ExecuteScript", "executeScript");
- plan->setProperty(execute_script, ExecuteScript::ScriptEngine, "");
- plan->setProperty(execute_script, ExecuteScript::ScriptFile,
"/path/to/script.lua");
+ REQUIRE_FALSE(plan->setProperty(execute_script, ExecuteScript::ScriptEngine,
""));
Review Comment:
why is this supposed to fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
