lordgamez commented on code in PR #1984:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1984#discussion_r2166088003


##########
extensions/lua/tests/TestExecuteScriptProcessorWithLuaScript.cpp:
##########
@@ -46,8 +46,8 @@ TEST_CASE("Script engine is not set", 
"[executescriptMisconfiguration]") {
 
   auto execute_script = plan->addProcessor("ExecuteScript", "executeScript");
 
-  plan->setProperty(execute_script, ExecuteScript::ScriptEngine, "");
-  plan->setProperty(execute_script, ExecuteScript::ScriptFile, 
"/path/to/script.lua");
+  REQUIRE_FALSE(plan->setProperty(execute_script, ExecuteScript::ScriptEngine, 
""));

Review Comment:
   The ScriptEngine property is configured to only allow "lua" and "python" 
values so it fails with setting empty string in it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to