[ 
https://issues.apache.org/jira/browse/NIFI-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849239#comment-15849239
 ] 

ASF GitHub Bot commented on NIFI-819:
-------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1462#discussion_r99034256
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
 ---
    @@ -62,18 +62,12 @@
     import org.apache.http.impl.client.HttpClientBuilder;
     import org.apache.http.impl.conn.BasicHttpClientConnectionManager;
     import org.apache.http.ssl.SSLContextBuilder;
    -import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.*;
     import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
    -import org.apache.nifi.annotation.behavior.Stateful;
    -import org.apache.nifi.annotation.behavior.WritesAttribute;
    -import org.apache.nifi.annotation.behavior.WritesAttributes;
     import org.apache.nifi.annotation.documentation.CapabilityDescription;
     import org.apache.nifi.annotation.documentation.Tags;
     import org.apache.nifi.annotation.lifecycle.OnScheduled;
    -import org.apache.nifi.components.AllowableValue;
    -import org.apache.nifi.components.PropertyDescriptor;
    -import org.apache.nifi.components.ValidationContext;
    -import org.apache.nifi.components.ValidationResult;
    +import org.apache.nifi.components.*;
    --- End diff --
    
    Should avoid the * imports.  This didn't seem to fail contrib-check for me, 
but is a rule in the checkstyle config


> Allow specification of headers for GetHTTP
> ------------------------------------------
>
>                 Key: NIFI-819
>                 URL: https://issues.apache.org/jira/browse/NIFI-819
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.2.1
>            Reporter: Aldrin Piri
>            Assignee: Andre
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> There is currently no way to provide additional headers for requests through 
> GetHTTP.  Some endpoints may require a token or other information to access 
> information.  Currently, it is possible to work around this with an 
> InvokeHttp driven by a dummy file, but interpretation of dynamic properties 
> added as additional headers would provide a better option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to