[ 
https://issues.apache.org/jira/browse/NIFI-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849256#comment-15849256
 ] 

ASF GitHub Bot commented on NIFI-819:
-------------------------------------

Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1462#discussion_r99038757
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java
 ---
    @@ -467,6 +486,18 @@ public void onTrigger(final ProcessContext context, 
final ProcessSessionFactory
                 if (accept != null) {
                     get.addHeader(HEADER_ACCEPT, accept);
                 }
    +
    +            // Add dynamic headers
    +
    +            PropertyValue customHeaderValue;
    +            for (PropertyDescriptor customProperty : customHeaders) {
    +                customHeaderValue = 
context.getProperty(customProperty).evaluateAttributeExpressions();
    +                if (StringUtils.isNotBlank(customHeaderValue.getValue())) {
    --- End diff --
    
    I was working under two assumptions:
    
    * onScheduled is called once per scheduling;
    * in theory use time related expression language even if incoming flowfiles 
were to be absent
    
    Does it make sense?


> Allow specification of headers for GetHTTP
> ------------------------------------------
>
>                 Key: NIFI-819
>                 URL: https://issues.apache.org/jira/browse/NIFI-819
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 0.2.1
>            Reporter: Aldrin Piri
>            Assignee: Andre
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> There is currently no way to provide additional headers for requests through 
> GetHTTP.  Some endpoints may require a token or other information to access 
> information.  Currently, it is possible to work around this with an 
> InvokeHttp driven by a dummy file, but interpretation of dynamic properties 
> added as additional headers would provide a better option.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to