scottyaslan commented on code in PR #10144:
URL: https://github.com/apache/nifi/pull/10144#discussion_r2243721042
##########
nifi-frontend/src/main/frontend/package.json:
##########
@@ -25,7 +25,14 @@
"@angular/platform-browser": "19.2.14",
"@angular/platform-browser-dynamic": "19.2.14",
"@angular/router": "19.2.14",
- "@ctrl/ngx-codemirror": "^7.0.0",
+ "@codemirror/autocomplete": "^6.8.14",
+ "@codemirror/commands": "^6.8.0",
+ "@codemirror/language": "^6.10.8",
+ "@codemirror/language-data": "^6.5.1",
+ "@codemirror/lang-javascript": "^6.2.2",
Review Comment:
Good questions. It turns out Codemirror V6 supports two different ways to
support language configuration. Direct Extension Import (Recommended) and
Dynamic Language Loading (via @codemirror/language-data includes 100+
languages). Since the codemirror editors in NiFi use the recommended extension
import I remove the @codemirror/language-data package and updated the
package.json to include all of the required extensions. I also updated the
Codemirror component to only support the direct extension import to simplify
the developer experience around configuring a Codemirror instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
