Re: [PR] [NIFI-14173] Codemirror V6 [nifi]

Wed, 30 Jul 2025 13:01:13 -0700 


scottyaslan commented on PR #10144:
URL: https://github.com/apache/nifi/pull/10144#issuecomment-3137651382

   > * Not sure where the issue is, but we've lost a bit of backward 
compatibility in terms of keyboard activation of EL/Param auto complete. 
Before, you used to be able to start with `${` or `#{` then hit `CMD + SPACE` 
to bring up the auto complete options. Now, with just those starting 
characters, it doesn't work. In fact, the console shows `detectedContext 
invalid`.
   >   If you add the closing `}` then move the cursor back in between them, 
this finally allows the auto-complete to work. Maybe its not the end of the 
world since when you type `${` or `#{` it will auto-add the `}` right after, 
but it feels weird.
   > * There seems to be some rendering differences when rendering details of a 
parameter or expression (EL). Things/subheadings that used to be bold are no 
longer bold:
   >   _Before:_
   > 
   > <img alt="Screenshot 2025-07-29 at 14 42 00" width="722" height="652" 
src="https://private-user-images.githubusercontent.com/713866/472152203-b9702bc2-ae6b-4555-baf7-75996e122160.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTM5MDQ1MDIsIm5iZiI6MTc1MzkwNDIwMiwicGF0aCI6Ii83MTM4NjYvNDcyMTUyMjAzLWI5NzAyYmMyLWFlNmItNDU1NS1iYWY3LTc1OTk2ZTEyMjE2MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNzMwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDczMFQxOTM2NDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNzBmNzZlZTIzNDQxNjA2NjFlMzgxOTQyMzY0ZmM0YjE5MzI5N2U1NjMzMDhjMzViMWYzYjBkZTc1MzFkODQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.eYHhneCjLIjyu-xc66GUtMwFRnhx9erLRmFSaYcM_ek";>
   > _After:_ <img alt="Screenshot 2025-07-29 at 14 41 47" width="958" 
height="418" 
src="https://private-user-images.githubusercontent.com/713866/472152225-232f03ee-c17f-4a71-b460-40b6b396b79f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTM5MDQ1MDIsIm5iZiI6MTc1MzkwNDIwMiwicGF0aCI6Ii83MTM4NjYvNDcyMTUyMjI1LTIzMmYwM2VlLWMxN2YtNGE3MS1iNDYwLTQwYjZiMzk2Yjc5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNzMwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDczMFQxOTM2NDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYWU4MzdkZWQ1NGY5MzdjNDkwMmVkYWRlN2I1MWNlZDI5YzQ3YWRlZTJiMzM5YjI5ODRiNzc4MzI3OTIxZWYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.o-WrvLJmpIUppb9HO4aYwbuN2cfGl1dIO-qImoLs4Bg";>
   
   Hmm, I don't see any console errors and I think you need to 'Ctrl + space' 
to open the auto complete. It seems to work as intended for me. I am also not 
seeing the same behavior you described with the matching bracket. If I type 
`${` or `#{` the matching closing bracket is added automatically and the cursor 
position is in between the brackets. If I type 'Ctrl + space` I see the 
autocomplete tooltip. Maybe you can try this again with my latest changes and 
let me know if you are still experiencing these issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to