szaszm commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2256901587
##########
utils/include/core/controller/ControllerService.h:
##########
@@ -105,6 +106,9 @@ class ControllerServiceImpl : public
ConfigurableComponentImpl, public Connectab
linked_services_ = services;
}
+
+ static constexpr auto ApiImplementations =
std::array<ControllerServiceApiDefinition, 0>{};
+
Review Comment:
Is this needed in the empty base class?
##########
minifi-api/include/minifi-cpp/controllers/SSLContextServiceInterface.h:
##########
@@ -33,8 +34,14 @@ namespace org::apache::nifi::minifi::controllers {
* Justification: Abstracts SSL support out of processors into a
* configurable controller service.
*/
-class SSLContextService : public virtual core::controller::ControllerService {
+class SSLContextServiceInterface : public virtual
core::controller::ControllerService {
public:
+ static constexpr auto ControllerServiceApiDefinition =
core::ControllerServiceApiDefinition{
+ .artifact = "minifi-system",
+ .group = "org.apache.nifi.minifi",
+ .type = "org.apache.nifi.minifi.controllers.SSLContextServiceInterface",
Review Comment:
Maybe we should call this SSLContextService on the interface, and hide the
interface-implementation relationship?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
