martinzink commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2257269388
##########
minifi-api/include/minifi-cpp/controllers/SSLContextServiceInterface.h:
##########
@@ -33,8 +34,14 @@ namespace org::apache::nifi::minifi::controllers {
* Justification: Abstracts SSL support out of processors into a
* configurable controller service.
*/
-class SSLContextService : public virtual core::controller::ControllerService {
+class SSLContextServiceInterface : public virtual
core::controller::ControllerService {
public:
+ static constexpr auto ControllerServiceApiDefinition =
core::ControllerServiceApiDefinition{
+ .artifact = "minifi-system",
+ .group = "org.apache.nifi.minifi",
+ .type = "org.apache.nifi.minifi.controllers.SSLContextServiceInterface",
Review Comment:
I think that could cause a whole lot of issues down the line for not much of
an upside.
And NiFi also has multiple SSLContextService implementations so I am not
sure if we wanna remove this separation any time soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
