lordgamez commented on code in PR #1993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1993#discussion_r2257042633
##########
CONFIGURE.md:
##########
@@ -657,16 +665,23 @@ As stated before each of the repositories can be
configured to be volatile (stat
**NOTE:** If the volatile repository reaches the maximum number of entries, it
will start to drop the oldest entries, and replace them with the new entries in
round robin manner. Make sure to set the maximum number of entries to a
reasonable value, so that the repository does not run out of memory.
### Configuring Repository storage locations
-Persistent repositories, such as the Flow File repository, use a configurable
path to store data.
-The repository locations and their defaults are defined below. By default the
MINIFI_HOME env
-variable is used. If this is not specified we extrapolate the path and use the
root installation
-folder. You may specify your own path in place of these defaults.
+Persistent repositories, such as the Flow File repository, use configurable
paths to store data. The application detects its installation type at runtime
and uses the appropriate default locations.
+
+In a self-contained installation (from a .tar.gz archive), paths are relative
to the application's root directory, which is typically configured using the
${MINIFI_HOME} environemnt variable. You may specify your own path in place of
these defaults.
Review Comment:
typo:
```suggestion
In a self-contained installation (from a .tar.gz archive), paths are
relative to the application's root directory, which is typically configured
using the ${MINIFI_HOME} environment variable. You may specify your own path in
place of these defaults.
```
##########
CONFIGURE.md:
##########
@@ -833,8 +848,14 @@ Additionally, a unique hexadecimal
uid.minifi.device.segment should be assigned
### Asset directory
-There is an asset directory specified using the `nifi.asset.directory` agent
property, which defaults to `${MINIFI_HOME}/asset`.
-The files referenced in the `.state` file in this directory are managed by the
agent. They are deleted, updated, downloaded
+## Asset Directory
Review Comment:
Are both second and third level headers with the same name necessary?
##########
CONFIGURE.md:
##########
@@ -74,6 +74,14 @@
- [Shortening log messages](#shortening-log-messages)
- [Recommended Antivirus Exclusions](#recommended-antivirus-exclusions)
+## Linux Installation types
+
+### Self-contained installation (from a .tar.gz archive)
+The `MINIFI_HOME` environment variable should point to the installation
directory, if `MINIFI_HOME` is not defined minifi will try to infer it from
binary's location.
Review Comment:
```suggestion
The `MINIFI_HOME` environment variable should point to the installation
directory, if `MINIFI_HOME` is not defined, MiNiFi will try to infer it from
binary's location.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
