szaszm commented on code in PR #1993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1993#discussion_r2291063391
##########
CONFIGURE.md:
##########
@@ -74,6 +74,14 @@
- [Shortening log messages](#shortening-log-messages)
- [Recommended Antivirus Exclusions](#recommended-antivirus-exclusions)
+## Linux Installation types
+
+### Self-contained installation (from a .tar.gz archive)
+The `MINIFI_HOME` environment variable should point to the installation
directory, if `MINIFI_HOME` is not defined, MiNiFi will try to infer it from
binary's location.
+
+### Filesystem Hierarchy Standard installation (from .rpm package)
+The `MINIFI_HOME` environment variable should be set to `FHS`, if
`MINIFI_HOME` is not defined but the binary is in the `/usr/bin` directory it
will try to run as a FHS application.
Review Comment:
```suggestion
The `MINIFI_HOME` environment variable should be set to `FHS`. If
`MINIFI_HOME` is not defined but the binary is in the `/usr/bin` directory it
will try to run as an FHS application.
```
##########
CONFIGURE.md:
##########
@@ -833,8 +848,12 @@ Additionally, a unique hexadecimal
uid.minifi.device.segment should be assigned
### Asset directory
-There is an asset directory specified using the `nifi.asset.directory` agent
property, which defaults to `${MINIFI_HOME}/asset`.
-The files referenced in the `.state` file in this directory are managed by the
agent. They are deleted, updated, downloaded
+The location for downloaded assets is specified by the `nifi.asset.directory`
agent property. The default path depends on the installation mode:
+
+* In a **self-contained (TGZ)** installation, this defaults to
**`${MINIFI_HOME}/asset`**.
+* In a **system-wide FHS** installation, the default is
**/var/lib/nifi-minifi-cpp/asset**.
Review Comment:
```suggestion
* In a **system-wide FHS** installation, the default is
**`/var/lib/nifi-minifi-cpp/asset`**.
```
##########
conf/minifi-log.properties.in:
##########
@@ -26,7 +26,7 @@ spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] %v
#spdlog.pattern=[%D %H:%M:%S.%e] [%L] %v
appender.rolling=rollingappender
-#appender.rolling.directory=${MINIFI_HOME}/logs
+#appender.rolling.directory=@MINIFI_PATH_APPENDER_ROLLING_DIR@
Review Comment:
Why not call it MINIFI_LOG_DIR?
##########
packaging/rpm/pre_install.sh:
##########
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+if ! getent group minificpp >/dev/null; then
+ groupadd -r minificpp
+fi
+
+if ! getent passwd minificpp >/dev/null; then
+ useradd -r -g minificpp -s /sbin/nologin -d /var/lib/nifi-minifi-cpp -c
"NiFi MiNiFi C++ Service Account" minificpp
+fi
+
+exit 0
Review Comment:
```suggestion
exit 0
```
##########
packaging/rpm/expected-rpm-contents.in:
##########
@@ -0,0 +1,67 @@
+/etc/nifi-minifi-cpp
+/etc/nifi-minifi-cpp/config.yml
+/etc/nifi-minifi-cpp/fips
+/etc/nifi-minifi-cpp/fips/openssl.cnf
+/etc/nifi-minifi-cpp/minifi-log.properties
+/etc/nifi-minifi-cpp/minifi-uid.properties
+/etc/nifi-minifi-cpp/minifi.properties
+/usr/bin/minifi
+/usr/bin/minifi-controller
+/usr/bin/minifi-encrypt-config
+/usr/lib64/nifi-minifi-cpp
+/usr/lib64/nifi-minifi-cpp/extensions
+@RPM_EXPECTED_EXTENSION_LIST@
+/usr/lib64/nifi-minifi-cpp/fips
+/usr/lib64/nifi-minifi-cpp/fips/fips.so
+/usr/lib64/nifi-minifi-cpp/fips/openssl
+/usr/lib64/nifi-minifi-cpp/libcore-minifi.so
+/usr/lib64/systemd/system/minifi.service
+/usr/share/doc/nifi-minifi-cpp
+/usr/share/doc/nifi-minifi-cpp/C2.md
+/usr/share/doc/nifi-minifi-cpp/CONAN.md
+/usr/share/doc/nifi-minifi-cpp/CONFIGURE.md
+/usr/share/doc/nifi-minifi-cpp/CONTRIBUTING.md
+/usr/share/doc/nifi-minifi-cpp/CONTROLLERS.md
+/usr/share/doc/nifi-minifi-cpp/EXPRESSIONS.md
+/usr/share/doc/nifi-minifi-cpp/Extensions.md
+/usr/share/doc/nifi-minifi-cpp/LICENSE
+/usr/share/doc/nifi-minifi-cpp/METRICS.md
+/usr/share/doc/nifi-minifi-cpp/NOTICE
+/usr/share/doc/nifi-minifi-cpp/OPS.md
+/usr/share/doc/nifi-minifi-cpp/PARAMETER_PROVIDERS.md
+/usr/share/doc/nifi-minifi-cpp/PROCESSORS.md
+/usr/share/doc/nifi-minifi-cpp/README.md
+/usr/share/doc/nifi-minifi-cpp/FIPS.md
+/usr/share/doc/nifi-minifi-cpp/ThirdParties.md
+/usr/share/doc/nifi-minifi-cpp/Windows.md
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/AddPythonAttribute.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/CountingProcessor.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/GaussianDistributionWithNumpy.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/MoveContentToJson.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/RemoveFlowFile.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/SentimentAnalysis.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/google
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/google/SentimentAnalyzer.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/h2o
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/h2o/ConvertDsToCsv.py
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/h2o/h2o3
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/h2o/h2o3/mojo
+/usr/share/doc/nifi-minifi-cpp/pythonprocessor-examples/h2o/h2o3/mojo/ExecuteH2oMojoScoring.py
+/var/lib/nifi-minifi-cpp
+/var/lib/nifi-minifi-cpp/minifi-python
+/var/lib/nifi-minifi-cpp/minifi-python/nifi_python_processors
+/var/lib/nifi-minifi-cpp/minifi-python/nifi_python_processors/__init__.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifi_python_processors/utils
+/var/lib/nifi-minifi-cpp/minifi-python/nifi_python_processors/utils/dependency_installer.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/__init__.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/componentstate.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/documentation.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/flowfilesource.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/flowfiletransform.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/processorbase.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/properties.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/recordtransform.py
+/var/lib/nifi-minifi-cpp/minifi-python/nifiapi/relationship.py
+/var/log/nifi-minifi-cpp
Review Comment:
in text files, all lines should have a line ending. Unfortunately some
editors treat them as line separators, and show an extra empty line at the end
if you have proper line endings.
```suggestion
/var/log/nifi-minifi-cpp
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
