martinzink commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2260724662
##########
minifi-api/include/minifi-cpp/controllers/RecordSetReader.h:
##########
@@ -30,6 +30,12 @@ namespace org::apache::nifi::minifi::core {
class RecordSetReader : public virtual controller::ControllerService {
public:
+ static constexpr auto ControllerServiceApiDefinition =
core::ControllerServiceApiDefinition{
Review Comment:
👍 good catch, I've added a test that would have failed
https://github.com/apache/nifi-minifi-cpp/pull/2001/commits/ded65512ca5985a1d92ff26b4b995333f97a2550
and fixed it in
https://github.com/apache/nifi-minifi-cpp/pull/2001/commits/2eacb4478f9306af31c0ce3a0a537384914d94ce
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
