exceptionfactory commented on code in PR #10207:
URL: https://github.com/apache/nifi/pull/10207#discussion_r2277698654
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java:
##########
@@ -202,13 +201,12 @@ public void initialize(final ResourceClaimManager
claimManager, final Repository
// delete backup. On restore, if no files exist in partition's
directory, would have to check backup directory
this.serdeFactory = serdeFactory;
- // The specified implementation can be plaintext or encrypted; the
only difference is the serde factory
- if (walImplementation.equals(SEQUENTIAL_ACCESS_WAL) ||
walImplementation.equals(ENCRYPTED_SEQUENTIAL_ACCESS_WAL)) {
+ try {
// TODO: May need to instantiate ESAWAL for clarity?
wal = new
SequentialAccessWriteAheadLog<>(flowFileRepositoryPaths.get(0), serdeFactory,
this);
- } else {
+ } catch (final Exception ex) {
Review Comment:
This `catch` seems unnecessary because there is only one implementation of
the Write-Ahead Log supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
