exceptionfactory commented on code in PR #10207:
URL: https://github.com/apache/nifi/pull/10207#discussion_r2279010781
##########
nifi-docs/src/main/asciidoc/administration-guide.adoc:
##########
@@ -2951,7 +2951,7 @@ Write-Ahead Log should be used. The default value is
`org.apache.nifi.wali.Seque
in order to address an issue that exists in the older implementation. In the
event of power loss or an operating system crash, the old implementation was
susceptible to recovering FlowFiles
incorrectly. This could potentially lead to the wrong attributes or content
being assigned to a FlowFile upon restart, following the power loss or OS
crash. However, one can still choose to opt into
using the previous implementation and accept that risk, if desired (for
example, if the new implementation were to exhibit some unexpected error).
-To do so, set the value of this property to
`org.wali.MinimalLockingWriteAheadLog`. Another available implementation is
`org.apache.nifi.wali.EncryptedSequentialAccessWriteAheadLog`.
+To do so, set the value of this property to
`org.wali.MinimalLockingWriteAheadLog`.
Review Comment:
This entire property description can now be removed since there are no other
implementations
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java:
##########
@@ -202,15 +191,8 @@ public void initialize(final ResourceClaimManager
claimManager, final Repository
// delete backup. On restore, if no files exist in partition's
directory, would have to check backup directory
this.serdeFactory = serdeFactory;
- // The specified implementation can be plaintext or encrypted; the
only difference is the serde factory
- if (walImplementation.equals(SEQUENTIAL_ACCESS_WAL) ||
walImplementation.equals(ENCRYPTED_SEQUENTIAL_ACCESS_WAL)) {
- // TODO: May need to instantiate ESAWAL for clarity?
- wal = new
SequentialAccessWriteAheadLog<>(flowFileRepositoryPaths.get(0), serdeFactory,
this);
- } else {
- throw new IllegalStateException("Cannot create Write-Ahead Log
because the configured property '" +
NiFiProperties.FLOWFILE_REPOSITORY_WAL_IMPLEMENTATION +
- "' has an invalid value of '" + walImplementation + "'.
Please update nifi.properties to indicate a valid value for this property.");
- }
-
+ // TODO: May need to instantiate ESAWAL for clarity?
Review Comment:
The `TODO` comment no longer applies, it was referring to the encrypted
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
