fgerlits commented on code in PR #2019:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2019#discussion_r2316233972


##########
core-framework/src/utils/ThreadPool.cpp:
##########


Review Comment:
   Do we need to make the same change in `manageWorkers()`?
   
   Also: if we only read/write `running_` under the mutex, do we still need it 
to be `atomic`?
   
   Also: `adjust_threads_` seems to be unused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to