lordgamez commented on code in PR #2019: URL: https://github.com/apache/nifi-minifi-cpp/pull/2019#discussion_r2316333335
########## core-framework/src/utils/ThreadPool.cpp: ########## Review Comment: I think we don't need to do this under the `manageWorkers()` because there is no conditional variable waiting to be notified, so this issue won't happen there, the worst that could happen that the loop will run one more time after the thread pool is stopped, but the shutdown will wait for it to join. The `running_` variable seems to be still used in other occurrences without a mutex, and as there are 2 mutexes here under which we also use the `running_` variable it could still happen that it is used by multiple threads so I would keep it as an atomic. It's a good pont that `adjust_threads_` is unused, I removed it in https://github.com/apache/nifi-minifi-cpp/pull/2019/commits/6931a54bf6e7e118f95fb162a4a569590ebcabc7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
