fgerlits commented on code in PR #2022:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2022#discussion_r2334075058


##########
libminifi/test/libtest/integration/IntegrationBase.cpp:
##########


Review Comment:
   Do we ever use the same harness object from more than one thread? The name 
`last_flow_config_path_` is confusing if it is only ever set once.
   
   Could the harness object create the temp directory and copy the config file 
(and resources?) there during construction, and just use it without copying in 
`run()`? That would seem simpler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to