lordgamez commented on code in PR #2022:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2022#discussion_r2334164542


##########
libminifi/test/libtest/integration/IntegrationBase.cpp:
##########


Review Comment:
   I think we don't use it more than once, but I have to check all cases first. 
The reason it was done this way is that the `test_file_path` is the parameter 
of the `run()`, but if it is only used once in all use cases then it can 
probably be refactored that the parameter is moved to the constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to