exceptionfactory commented on code in PR #10292:
URL: https://github.com/apache/nifi/pull/10292#discussion_r2350484354
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/PutKinesisStream.java:
##########
@@ -95,8 +94,7 @@ public class PutKinesisStream extends
AbstractAwsSyncProcessor<KinesisClient, Ki
.build();
public static final PropertyDescriptor MAX_MESSAGE_BUFFER_SIZE_MB = new
PropertyDescriptor.Builder()
- .name("max-message-buffer-size")
- .displayName("Max message buffer size (MB)")
+ .name("Max message buffer size (MB)")
.description("Max message buffer size in Mega-bytes")
Review Comment:
This should also be adjusted.
```suggestion
.description("Max message buffer size defined with standard data
size units")
```
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/PutKinesisStream.java:
##########
@@ -95,8 +94,7 @@ public class PutKinesisStream extends
AbstractAwsSyncProcessor<KinesisClient, Ki
.build();
public static final PropertyDescriptor MAX_MESSAGE_BUFFER_SIZE_MB = new
PropertyDescriptor.Builder()
- .name("max-message-buffer-size")
- .displayName("Max message buffer size (MB)")
+ .name("Max message buffer size (MB)")
Review Comment:
The name should be changed to standard conventions:
```suggestion
.name("Max Message Buffer Size")
```
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/PutKinesisStream.java:
##########
@@ -105,8 +103,7 @@ public class PutKinesisStream extends
AbstractAwsSyncProcessor<KinesisClient, Ki
.build();
static final PropertyDescriptor KINESIS_STREAM_NAME = new
PropertyDescriptor.Builder()
- .name("kinesis-stream-name")
- .displayName("Amazon Kinesis Stream Name")
+ .name("Amazon Kinesis Stream Name")
Review Comment:
This can be simplified:
```suggestion
.name("Stream Name")
```
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java:
##########
@@ -181,6 +175,17 @@ public class ConsumeAMQP extends
AbstractAMQPProcessor<AMQPConsumer> {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ @Override
+ public void migrateProperties(final PropertyConfiguration config) {
Review Comment:
Missing `super.migrateProperties()`
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/PutKinesisStream.java:
##########
@@ -76,17 +77,15 @@ public class PutKinesisStream extends
AbstractAwsSyncProcessor<KinesisClient, Ki
public static final String AWS_KINESIS_SEQUENCE_NUMBER =
"aws.kinesis.sequence.number";
public static final PropertyDescriptor KINESIS_PARTITION_KEY = new
PropertyDescriptor.Builder()
- .displayName("Amazon Kinesis Stream Partition Key")
- .name("amazon-kinesis-stream-partition-key")
+ .name("Amazon Kinesis Stream Partition Key")
Review Comment:
"Amazon Kinesis" is redundant since it is in the context of the Processor.
```suggestion
.name("Stream Partition Key")
```
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -210,6 +210,11 @@ protected AMQPPublisher createAMQPWorker(final
ProcessContext context, final Con
return new AMQPPublisher(connection, getLogger());
}
+ @Override
+ public void migrateProperties(final PropertyConfiguration config) {
Review Comment:
It looks like is missing a `super.migrateProperties()` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
