dan-s1 commented on PR #10292:
URL: https://github.com/apache/nifi/pull/10292#issuecomment-3285564311

   @exceptionfactory I understand for the those unit tests which test the 
properties defined in the actual processor. But what about processors which 
inherit properties from a parent and have their own properties defined? I would 
think we would want to to test `super.migrateProperties` was called to ensure 
all properties are renamed. In fact I had pointed out to you on the Jira ticket 
a case in point where `super.migrateProperties` was not called but should have 
been. Also when working the Azure code I noticed there are properties defined 
in utility classes and not the actual processor/controller service and used 
across various processors/controller services. Wouldn't it be a good idea to to 
test those migrations?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to