fgerlits commented on code in PR #2036: URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376086865
########## cmake/AzureSdkCpp.cmake: ########## @@ -55,3 +55,8 @@ FetchContent_Declare(asdkext ) FetchContent_MakeAvailable(asdkext) + +if (NOT WIN32) + add_dependencies(azure-storage-common LibXml2::LibXml2) + add_dependencies(azure-data-tables LibXml2::LibXml2) +endif() Review Comment: why is this not needed on Windows? ########## CMakeLists.txt: ########## @@ -370,7 +370,7 @@ add_subdirectory(core-framework) add_subdirectory(extension-framework) add_subdirectory(libminifi) -if (ENABLE_ALL OR ENABLE_AZURE) +if (NOT WIN32 AND (ENABLE_ALL OR ENABLE_AZURE)) Review Comment: also here; why is Windows excluded? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
