lordgamez commented on code in PR #2036:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2036#discussion_r2376120434
##########
cmake/AzureSdkCpp.cmake:
##########
@@ -55,3 +55,8 @@ FetchContent_Declare(asdkext
)
FetchContent_MakeAvailable(asdkext)
+
+if (NOT WIN32)
+ add_dependencies(azure-storage-common LibXml2::LibXml2)
+ add_dependencies(azure-data-tables LibXml2::LibXml2)
+endif()
Review Comment:
In both azure storage and azure data tables target libxml2 is only used in
non-windows builds:
```
if(WIN32)
target_link_libraries(azure-storage-common PRIVATE bcrypt webservices)
else()
find_package(LibXml2 REQUIRED)
target_include_directories(azure-storage-common SYSTEM PRIVATE
${LIBXML2_INCLUDE_DIRS})
target_link_libraries(azure-storage-common PRIVATE ${LIBXML2_LIBRARIES})
find_package(OpenSSL REQUIRED)
target_link_libraries(azure-storage-common PRIVATE OpenSSL::SSL
OpenSSL::Crypto)
endif()
```
##########
CMakeLists.txt:
##########
@@ -370,7 +370,7 @@ add_subdirectory(core-framework)
add_subdirectory(extension-framework)
add_subdirectory(libminifi)
-if (ENABLE_ALL OR ENABLE_AZURE)
+if (NOT WIN32 AND (ENABLE_ALL OR ENABLE_AZURE))
Review Comment:
Only azure uses libxml2 as a thirdparty dependency and only in non-windows
builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
