sardell commented on code in PR #10346:
URL: https://github.com/apache/nifi/pull/10346#discussion_r2379890984
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/buckets.service.ts:
##########
@@ -37,6 +39,61 @@ export class BucketsService {
// });
// return throwError(() => mockError);
- return this.httpClient.get(`${BucketsService.API}/buckets`);
+ return this.httpClient.get<Bucket[]>(`${BucketsService.API}/buckets`);
+ }
+
+ createBucket(request: CreateBucketRequest): Observable<Bucket> {
+ // const mockError: HttpErrorResponse = new HttpErrorResponse({
Review Comment:
Do we want to leave this commented code in all these service methods? Unless
I'm developing/testing a specific error code and the resulting behavior, I
usually just stop the backend and attempt to make the request from the UI.
Although the status is different (500 internal server error), I'm not seeing
the advantage to leaving these comments for future testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
