scottyaslan commented on code in PR #10346:
URL: https://github.com/apache/nifi/pull/10346#discussion_r2388254124
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/service/buckets.service.ts:
##########
@@ -37,6 +39,61 @@ export class BucketsService {
// });
// return throwError(() => mockError);
- return this.httpClient.get(`${BucketsService.API}/buckets`);
+ return this.httpClient.get<Bucket[]>(`${BucketsService.API}/buckets`);
+ }
+
+ createBucket(request: CreateBucketRequest): Observable<Bucket> {
+ // const mockError: HttpErrorResponse = new HttpErrorResponse({
Review Comment:
I think we do want to keep these here. They are here to make it easy to test
all the error handling scenarios. We don't want to leave the error scenario
turned on for the dev server as we want the application to behave normally but
we want to be able to quickly test error scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
