sardell commented on code in PR #10399:
URL: https://github.com/apache/nifi/pull/10399#discussion_r2427292489
##########
nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/buckets/feature/ui/manage-bucket-policies-dialog/manage-bucket-policies-dialog.component.html:
##########
@@ -15,16 +15,87 @@
~ limitations under the License.
-->
-<h2 mat-dialog-title>Manage Bucket Policies</h2>
-<mat-dialog-content>
- <div class="flex flex-col gap-y-4">
- <p>
- TODO: Manage policies for bucket: <strong>{{ data.bucket.name
}}</strong>
- </p>
- <!-- TODO: Manage policies for bucket -->
+<h2 mat-dialog-title>{{ data.bucket.name }}<span
class="ml-2">Policies</span></h2>
+<mat-dialog-content class="dialog-content">
+ <div class="policy-table flex flex-col h-full gap-y-3">
+ <div class="flex justify-between items-center">
+ <div class="flex justify-end w-full">
+ <button mat-icon-button class="primary-icon-button"
(click)="addPolicy()" [disabled]="loading$ | async">
+ <i class="fa fa-plus"></i>
+ </button>
+ </div>
+ </div>
+
+ <div class="listing-table select-none flex flex-1 h-full">
+ <div class="flex-1 relative">
+ <div class="absolute inset-0 overflow-y-auto
overflow-x-hidden">
+ <table
+ mat-table
+ [dataSource]="dataSource"
+ matSort
+ matSortDisableClear
+ (matSortChange)="sortData($event)"
+ [matSortActive]="sort.active"
+ [matSortDirection]="sort.direction">
+ <!-- Type Column -->
+ <ng-container matColumnDef="type">
+ <th mat-header-cell *matHeaderCellDef
mat-sort-header>Type</th>
+ <td mat-cell *matCellDef="let row">
+ <i class="fa mr-2" [ngClass]="row.type ===
'group' ? 'fa-users' : ''"></i>
Review Comment:
```suggestion
<i class="fa mr-2" [ngClass]="row.type ===
'group' ? 'fa-users' : 'fa-user'"></i>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
