scottyaslan commented on code in PR #10399: URL: https://github.com/apache/nifi/pull/10399#discussion_r2434089293
########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/buckets/feature/ui/add-policy-to-bucket-dialog/add-policy-to-bucket-dialog.component.html: ########## @@ -0,0 +1,78 @@ +<!-- +~ Licensed to the Apache Software Foundation (ASF) under one or more +~ contributor license agreements. See the NOTICE file distributed with +~ this work for additional information regarding copyright ownership. +~ The ASF licenses this file to You under the Apache License, Version 2.0 +~ (the "License"); you may not use this file except in compliance with +~ the License. You may obtain a copy of the License at +~ +~ http://www.apache.org/licenses/LICENSE-2.0 +~ +~ Unless required by applicable law or agreed to in writing, software +~ distributed under the License is distributed on an "AS IS" BASIS, +~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +~ See the License for the specific language governing permissions and +~ limitations under the License. +--> + +<h2 mat-dialog-title>New Policy</h2> +<mat-dialog-content class="dialog-content"> + <div class="flex flex-col h-full gap-y-4"> + <div class="listing-table select-none flex flex-1"> + <div class="flex-1 relative"> + <div class="absolute inset-0 overflow-y-auto overflow-x-hidden"> + <table + mat-table + [dataSource]="dataSource" + matSort + matSortDisableClear + (matSortChange)="sortData($event)" + [matSortActive]="sort.active" + [matSortDirection]="sort.direction"> + <!-- Identity Column --> + <ng-container matColumnDef="identity"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>Identity</th> + <td mat-cell *matCellDef="let row"> + <div class="flex items-center gap-x-2"> + <i class="fa mr-2" [ngClass]="row.type === 'group' ? 'fa-users' : ''"></i> Review Comment: In the old Ui we only showed an icon for groups not users so that is what I followed here. ########## nifi-frontend/src/main/frontend/apps/nifi-registry/src/app/pages/buckets/feature/ui/manage-bucket-policies-dialog/manage-bucket-policies-dialog.component.html: ########## @@ -15,16 +15,87 @@ ~ limitations under the License. --> -<h2 mat-dialog-title>Manage Bucket Policies</h2> -<mat-dialog-content> - <div class="flex flex-col gap-y-4"> - <p> - TODO: Manage policies for bucket: <strong>{{ data.bucket.name }}</strong> - </p> - <!-- TODO: Manage policies for bucket --> +<h2 mat-dialog-title>{{ data.bucket.name }}<span class="ml-2">Policies</span></h2> +<mat-dialog-content class="dialog-content"> + <div class="policy-table flex flex-col h-full gap-y-3"> + <div class="flex justify-between items-center"> + <div class="flex justify-end w-full"> + <button mat-icon-button class="primary-icon-button" (click)="addPolicy()" [disabled]="loading$ | async"> + <i class="fa fa-plus"></i> + </button> + </div> + </div> + + <div class="listing-table select-none flex flex-1 h-full"> + <div class="flex-1 relative"> + <div class="absolute inset-0 overflow-y-auto overflow-x-hidden"> + <table + mat-table + [dataSource]="dataSource" + matSort + matSortDisableClear + (matSortChange)="sortData($event)" + [matSortActive]="sort.active" + [matSortDirection]="sort.direction"> + <!-- Type Column --> + <ng-container matColumnDef="type"> + <th mat-header-cell *matHeaderCellDef mat-sort-header>Type</th> + <td mat-cell *matCellDef="let row"> + <i class="fa mr-2" [ngClass]="row.type === 'group' ? 'fa-users' : ''"></i> Review Comment: In the old Ui we only showed an icon for groups not users so that is what I followed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
