turcsanyip commented on PR #10401: URL: https://github.com/apache/nifi/pull/10401#issuecomment-3378636567
@exceptionfactory Thanks for highlighting this issue. Actually, the changed behavior was not applied in `JWTBearerOAuth2AccessTokenProvider` which should be adjusted. However, I would not introduce alternative methods because the real problem is that the current `getExpiredIn()` and `isExpired()` methods do not handle a valid scenario (permanent tokens). In that case we would keep `getExpiredIn()` and `isExpired()` fully compatible but containing the bug. Instead, I would suggest modifying the type to `Long` and adjusting all usages in the codebase. As this is a component interface and is not part of `nifi-api`, I don't think we must follow strict compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
