exceptionfactory commented on code in PR #10401:
URL: https://github.com/apache/nifi/pull/10401#discussion_r2578504803
##########
nifi-extension-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/StandardOauth2AccessTokenProvider.java:
##########
@@ -456,11 +467,19 @@ private void getProperties(ConfigurationContext context) {
}
private boolean isRefreshRequired() {
- final Instant expirationRefreshTime = accessDetails.getFetchTime()
- .plusSeconds(accessDetails.getExpiresIn())
- .minusSeconds(refreshWindowSeconds);
+ if (accessDetails.getExpiresIn() != null) {
+ final Instant expirationRefreshTime = accessDetails.getFetchTime()
+ .plusSeconds(accessDetails.getExpiresIn())
+ .minusSeconds(refreshWindowSeconds);
- return Instant.now().isAfter(expirationRefreshTime);
+ return Instant.now().isAfter(expirationRefreshTime);
+ } else {
+ final Instant expirationRefreshTime = accessDetails.getFetchTime()
+ .plusSeconds(defaultExpirationTimeSeconds)
+ .minusSeconds(refreshWindowSeconds);
+
+ return Instant.now().isAfter(expirationRefreshTime);
+ }
Review Comment:
It looks like this could be refactored to a single `return` and also the
value of expiration time could be the element to set conditionally so that it
would read something like
```
final long expirationRefreshTime;
if (accessDetails.getExpiresIn() == null) {
expirationRefreshTime = defaultExpirationTimeSeconds;
} else {
expirationRefreshTime = accessDetails.getExpiresIn;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
