ravinarayansingh commented on PR #10405:
URL: https://github.com/apache/nifi/pull/10405#issuecomment-3460188543

   > Thanks for the updates @ravinarayansingh. This looks better, but handling 
`IGNORE`, `REJECT`, and `FAIL` with the same case does not seem correct. The 
IGNORE and NONE options should not log a warning as previously mentioned, and 
the other two options require routing to a different location.
   
   Thanks for the feedback, @exceptionfactory.
   Just to confirm, for the IGNORE and NONE conflict resolution strategies, 
I’ll keep the log level as INFO, like this:
   ```
   case FileTransfer.CONFLICT_RESOLUTION_IGNORE:
   case FileTransfer.CONFLICT_RESOLUTION_NONE:
       getLogger().info("Configured to {} on move conflict for {}. Original 
remote file will be left in place.", strategy, flowFile);
       return;
                               
   ```
   For the other two options — REJECT and FAIL — should these also log a 
warning, or should they additionally route the FlowFile to a different 
relationship (for example, failure or reject)?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to