ravinarayansingh commented on code in PR #10405:
URL: https://github.com/apache/nifi/pull/10405#discussion_r2493246927
##########
nifi-extension-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FetchFileTransfer.java:
##########
@@ -327,6 +350,101 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
}
+ private boolean handleCompletionPreCommit(final FileTransfer transfer,
Review Comment:
Hi @exceptionfactory
Thanks for the feedback. I’ve refactored the FetchFileTransfer logic to
simplify control flow and reduce nesting.
- Centralized MOVE pre-commit
- Modularized MOVE conflict resolution using dedicated methods
(resolveMoveConflict and handleMovePreCommit).
- Improved logging and failure routing for clearer debugging and error
visibility.
Please review the updated implementation and let me know if it aligns with
your expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
