exceptionfactory commented on code in PR #10485: URL: https://github.com/apache/nifi/pull/10485#discussion_r2487907582
########## nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/credentials/service/StandardGCPIdentityFederationTokenProviderTest.java: ########## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.gcp.credentials.service; + +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.oauth2.AccessToken; +import org.apache.nifi.oauth2.OAuth2AccessTokenProvider; +import org.apache.nifi.util.NoOpProcessor; +import org.apache.nifi.util.TestRunner; +import org.apache.nifi.util.TestRunners; +import org.apache.nifi.web.client.api.HttpEntityHeaders; +import org.apache.nifi.web.client.api.HttpRequestBodySpec; +import org.apache.nifi.web.client.api.HttpRequestHeadersSpec; +import org.apache.nifi.web.client.api.HttpRequestMethod; +import org.apache.nifi.web.client.api.HttpRequestUriSpec; +import org.apache.nifi.web.client.api.HttpResponseEntity; +import org.apache.nifi.web.client.api.HttpUriBuilder; +import org.apache.nifi.web.client.api.WebClientService; +import org.apache.nifi.web.client.provider.api.WebClientServiceProvider; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.ByteArrayInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.net.URI; +import java.net.URLEncoder; +import java.nio.charset.StandardCharsets; +import java.util.Collection; +import java.util.List; +import java.util.Optional; +import java.util.OptionalLong; + +import static org.apache.nifi.processors.gcp.credentials.service.StandardGCPIdentityFederationTokenProvider.AUDIENCE; +import static org.apache.nifi.processors.gcp.credentials.service.StandardGCPIdentityFederationTokenProvider.SUBJECT_TOKEN_PROVIDER; +import static org.apache.nifi.processors.gcp.credentials.service.StandardGCPIdentityFederationTokenProvider.WEB_CLIENT_SERVICE; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class StandardGCPIdentityFederationTokenProviderTest { + private static final String SERVICE_ID = "federation-provider"; + private static final String SUBJECT_PROVIDER_ID = "subject-token-provider"; + private static final String WEB_CLIENT_SERVICE_ID = "web-client"; + private static final String SAMPLE_AUDIENCE = "//iam.googleapis.com/projects/123456789/locations/global/workloadIdentityPools/sample/providers/provider-id"; + private static final String SAMPLE_ACCESS_TOKEN = "ya29.sample-access-token"; + private static final String SUBJECT_TOKEN = "subject-token"; + + private TestRunner runner; + private StandardGCPIdentityFederationTokenProvider tokenProvider; + private CapturingWebClientServiceProvider webClientServiceProvider; + private MockSubjectTokenProvider subjectTokenProvider; + + @BeforeEach + public void setUp() throws Exception { + runner = TestRunners.newTestRunner(NoOpProcessor.class); + tokenProvider = new StandardGCPIdentityFederationTokenProvider(); + runner.addControllerService(SERVICE_ID, tokenProvider); + + webClientServiceProvider = new CapturingWebClientServiceProvider(); + runner.addControllerService(WEB_CLIENT_SERVICE_ID, webClientServiceProvider); + runner.enableControllerService(webClientServiceProvider); + + subjectTokenProvider = new MockSubjectTokenProvider(); + runner.addControllerService(SUBJECT_PROVIDER_ID, subjectTokenProvider); + runner.enableControllerService(subjectTokenProvider); + } + + @Test + public void testTokenExchange() throws Exception { + runner.setProperty(tokenProvider, WEB_CLIENT_SERVICE, WEB_CLIENT_SERVICE_ID); + runner.setProperty(tokenProvider, SUBJECT_TOKEN_PROVIDER, SUBJECT_PROVIDER_ID); + runner.setProperty(tokenProvider, AUDIENCE, SAMPLE_AUDIENCE); + + runner.enableControllerService(tokenProvider); + runner.assertValid(tokenProvider); + + final AccessToken accessToken = tokenProvider.getAccessDetails(); + assertNotNull(accessToken); + assertEquals(SAMPLE_ACCESS_TOKEN, accessToken.getAccessToken()); + + final String requestBody = webClientServiceProvider.getCapturedRequestBody(); + assertNotNull(requestBody); + assertEquals(StandardGCPIdentityFederationTokenProviderTest.SUBJECT_TOKEN, subjectTokenProvider.getProvidedToken()); + assertEquals(URI.create("https://sts.googleapis.com/v1/token";), webClientServiceProvider.getCapturedRequestUri()); + // Validate core parameters are present + final String expectedAudienceParam = "audience=" + encode(SAMPLE_AUDIENCE); + final String expectedSubjectParam = "subject_token=" + encode(SUBJECT_TOKEN); + final String expectedGrantType = "grant_type=" + encode("urn:ietf:params:oauth:grant-type:token-exchange"); + + assertTrue(requestBody.contains(expectedAudienceParam)); + assertTrue(requestBody.contains(expectedSubjectParam)); + assertTrue(requestBody.contains(expectedGrantType)); + } + + private static String encode(final String value) { + return URLEncoder.encode(value, StandardCharsets.UTF_8); + } + + private static final class MockSubjectTokenProvider extends AbstractControllerService implements OAuth2AccessTokenProvider { + private String providedToken; + + @Override + public AccessToken getAccessDetails() { + final AccessToken accessToken = new AccessToken(); + accessToken.setAdditionalParameter("id_token", StandardGCPIdentityFederationTokenProviderTest.SUBJECT_TOKEN); + providedToken = StandardGCPIdentityFederationTokenProviderTest.SUBJECT_TOKEN; + return accessToken; + } + + public String getProvidedToken() { + return providedToken; + } + + @Override + public void refreshAccessDetails() { + // no-op + } + } + + private static final class CapturingWebClientServiceProvider extends AbstractControllerService implements WebClientServiceProvider { Review Comment: Did you consider using a Mockito Spy as opposed to implementing the entire interface? That may be a cleaner option that could support capturing expected values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
