turcsanyip commented on PR #10485: URL: https://github.com/apache/nifi/pull/10485#issuecomment-3487659636
@pvillard31 Thanks for the refactoring to use IdentityPoolCredentials. The token refresh now works as expected. I will do a more thorough review and testing. A high level / conceptual question: Is there a specific reason why the new type of credentials was implemented as a separate controller service? I mean it could be a new `CredentialsStrategy` implementation within `GCPCredentialsControllerService` like the existing ones. This way, it would fit more into the existing design. I see that there are a couple of properties that belong to this new credential type but the properties could be isolated via adding a 'Credential Type' property with dependent properties in `GCPCredentialsControllerService`. What is your opinion on this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
