martinzink commented on code in PR #2044: URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2503057555
########## extensions/azure/tests/features/environment.py: ########## Review Comment: good idea 👍 [added explanatory comments to environment.pys](https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/1c9e4c846f612c52e324d46298a19061bfa84623) ########## .github/workflows/create-release-artifacts.yml: ########## @@ -0,0 +1,42 @@ +name: "Create Release Artifacts" + +on: [workflow_dispatch] +env: + CMAKE_FLAGS: -DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DENABLE_ALL=ON -DMINIFI_FAIL_ON_WARNINGS=OFF -DDOCKER_BUILD_ONLY=ON Review Comment: good idea, [DCI_BUILD=OFF in create-release-artifacts.yml](https://github.com/apache/nifi-minifi-cpp/pull/2044/commits/47827dceca23d3eafe26f349921d037b8629fcd5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
